Skip to content

Subscription Details: fix table styles and skeleton

Angelo Gulina requested to merge ag-273028-subs-details-ui-fix into master

What does this MR do?

This MR is a quick fix following up this comment on the related MR. It's:

  • using a table structure to align the labels and content
  • determining how many skeleton loader lines to show, based on the fix amount of details
  • update needed implementation and tests

Note that, as described in the MR series, there is no actual visible UI change that will be presented to the user. The screenshots are added as a quick way to check the result.

To see the changes locally

Use Rails console to run:

ApplicationSetting.current.update(cloud_license_enabled: true)

Use the following patches:

Screenshots (strongly suggested)

Desktop

Loading Loaded
Screenshot_2021-04-01_at_22.44.50 Screenshot_2021-04-01_at_22.45.12

Mobile

Loading Loaded
Screenshot_2021-04-01_at_23.15.10 Screenshot_2021-04-01_at_23.17.07

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Angelo Gulina

Merge request reports