Skip to content

Handle GRPC::NotFound in Gitaly tree_entry call

What does this MR do?

Prepares the rails backend for gitaly!3078 (merged) so we can make that breaking change as part of %14.0.

Screenshots (strongly suggested)

Test setup: For all four combinations of this MR and gitaly!3078 (merged), visit a non-existing file

Results: As expected, 404 in all situations except when the gitaly change is applied without this MR, since that error is currently unhandled.

without rails change with rails change
without gitaly change 00_without_rails_without_gitaly 10_with_rails_without_gitaly
with gitaly change 01_without_rails_with_gitaly 11_with_rails_with_gitaly

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Hordur Freyr Yngvason

Merge request reports