Handle GRPC::NotFound in Gitaly tree_entry call
What does this MR do?
Prepares the rails backend for gitaly!3078 (merged) so we can make that breaking change as part of %14.0.
Screenshots (strongly suggested)
Test setup: For all four combinations of this MR and gitaly!3078 (merged), visit a non-existing file
Results: As expected, 404 in all situations except when the gitaly change is applied without this MR, since that error is currently unhandled.
without rails change | with rails change | |
---|---|---|
without gitaly change | ||
with gitaly change |
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because this change is entirely invisible to the user.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Hordur Freyr Yngvason