TreeEntry: return gRPC NotFound when entry not found (!3078) · Merge requests · GitLab.org / gitaly

Mikhail Mazurskiy requested to merge ash2k/tree-entry-not-found into master Feb 01, 2021

This MR changes the TreeEntry API to return gRPC NotFound when entry was not found.

Current behavior is to return an empty response, which is not a great API. It's hard to use and led to a bug in GitLab Kubernetes Agent: gitlab-org/cluster-integration/gitlab-agent#88 (closed). See the MR for more details: gitlab-org/cluster-integration/gitlab-agent!267 (merged), specifically internal/gitaly/path_fetcher.go.

It's a breaking change for existing clients, so I guess it cannot be merged as is. I'm opening this MR anyway to start a conversation. Maybe there is a way forward still (e.g. a new API method?).

TreeEntry: return gRPC NotFound when entry not found

Merge request reports