Replace bootstrap modal for delete branch modal [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
Adds a new component for delete branch confirmation modal, and a new component to open it.
Adds feature flag :delete_branch_confirmation_modals
which when enabled:
-
Replaces both the bootstrap modal and the javascript alert window on the Branches page with the new vue GlModal component.
-
Replaces the delete branch icon buttons on the Branches page with newly added button components to open the new vue confirmation modal.
Related to #254257 (closed)
Related to epic &4386
Feature flag rollout issue: https://gitlab.com/gitlab-org/gitlab/-/issues/329052
Screenshots (strongly suggested)
before (regular branch) | after (tooltip and confirmation) |
---|---|
merged: | merged: |
unmerged: | unmerged: |
before (protected branch) | after (tooltip and confirmation) |
---|---|
not allowed: allowed: merged: unmerged: | not allowed: allowed: merged: unmerged: |
before (default branch) | after |
---|---|
there is no style on the GlToolTip directive when the GLButton is disabled |
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #254257 (closed)