Create dast_failed_site_validations feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
Create the dast_failed_site_validations
feature flag and makes it available to the DAST profiles library.
Related to #323961 (closed)
Merge request reports
Activity
added Category:DAST feature flag groupdynamic analysis labels
added 1 commit
- caa187f6 - Create dast_failed_site_validations feature flag
added 1 commit
- 02599f15 - Create dast_failed_site_validations feature flag
added backend label
1 Warning ⚠ You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.2 Messages 📖 CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 56146 "Create dast_failed_site_validations feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 56146 "Create dast_failed_site_validations feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
📖 You're adding or removing a feature flag, your MR title needs to include [RUN ALL RSPEC] [RUN AS-IF-FOSS]
(we may have updated it automatically for you and started a new MR pipeline) to ensure everything is covered.Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Alexandru Croitor ( @acroitor
) (UTC+2, 7 hours ahead of@pgascouvaillancourt
)Kerri Miller ( @kerrizor
) (UTC-8, 3 hours behind@pgascouvaillancourt
)~feature_flag No reviewer available No maintainer available If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖changed milestone to %13.10
- Resolved by Gabriel Mazetto
@brodock could you give this a look please?
assigned to @brodock and unassigned @pgascouvaillancourt
requested review from @brodock
added 17 commits
-
02599f15...44c6716c - 16 commits from branch
master
- 082916fc - Create dast_failed_site_validations feature flag
-
02599f15...44c6716c - 16 commits from branch
added 16 commits
-
082916fc...2be0aa5b - 15 commits from branch
master
- 76a446d5 - Create dast_failed_site_validations feature flag
-
082916fc...2be0aa5b - 15 commits from branch
added typemaintenance label
added typefeature label
@pgascouvaillancourt LGTM! I've set to MWPS
🚀 enabled an automatic merge when the pipeline for 5c01e217 succeeds