Skip to content

Fix cop FactoryBot/InlineAssociation offenses for geo event log

What does this MR do?

Contributes to #267606 (closed)

Other offenses

While at it, the following (hidden by default) RuboCop offenses has also been fixed:

Inspecting 1 file
C

Offenses:

ee/spec/factories/geo/event_log.rb:104:31: C: Style/StringConcatenation: Prefer string interpolation to string concatenation.
    new_path_with_namespace { project.path_with_namespace + '_new' }
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ee/spec/factories/geo/event_log.rb:106:36: C: Style/StringConcatenation: Prefer string interpolation to string concatenation.
    new_wiki_path_with_namespace { project.wiki.path_with_namespace + '_new' }
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ee/spec/factories/geo/event_log.rb:108:16: C: Style/StringConcatenation: Prefer string interpolation to string concatenation.
    new_path { project.path + '_new' }
               ^^^^^^^^^^^^^^^^^^^^^
ee/spec/factories/geo/event_log.rb:116:21: C: Style/StringConcatenation: Prefer string interpolation to string concatenation.
    new_disk_path { project.path_with_namespace + '_new' }
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ee/spec/factories/geo/event_log.rb:118:26: C: Style/StringConcatenation: Prefer string interpolation to string concatenation.
    new_wiki_disk_path { project.wiki.path_with_namespace + '_new' }
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Does this MR meet the acceptance criteria?

Conformity

Edited by Peter Leitzen

Merge request reports