Fix cop remaining cop offenses for FactoryBot/InlineAssociation
Problem
In !44840 (merged) we've introduced a new FactoryBot/InlineAssociation
to encourage the use of inline associations in FactoryBot
discouraging explicit use of create
and build
.
This MR enabled the
Proposed solution
Resolve auto-correctable file by letting RuboCop auto-correct them automatically
- Pick a file from The List below e.g.
ee/spec/factories/ci/reports/security/reports.rb
- Create a branch (e.g.
pl-rubocop-inline-association-security-reports
) - Delete the file from
.rubocop_manual_todo.yml
- Let RuboCop auto-correct the offenses via e.g.
bundle exec rubocop --auto-correct --only FactoryBot/InlineAssociation spec/factories ee/spec/factories
- Check changes files and adjust if needed
- Commit and create a merge request adding
Contributes to #267606
and static code analysis label - Tick off the checkbox(es) and add the MR or mention this merge request in this issue
🎉
The List
The following offenses need to be fixed:
-
ee/spec/factories/analytics/cycle_analytics/group_stages.rb
- !55915 (merged) -
ee/spec/factories/ci/reports/security/findings.rb
- !45527 (merged) -
ee/spec/factories/ci/reports/security/reports.rb
- !45527 (merged) -
ee/spec/factories/geo/event_log.rb
- !55919 (merged) -
ee/spec/factories/groups.rb
- !48166 (merged) -
ee/spec/factories/merge_request_blocks.rb
- !56241 (merged) -
ee/spec/factories/resource_iteration_event.rb
- !46038 (merged) -
ee/spec/factories/resource_weight_events.rb
- !46038 (merged) -
ee/spec/factories/vulnerabilities/feedback.rb
- !56241 (merged) -
spec/factories/atlassian_identities.rb
- !56691 (merged) -
spec/factories/audit_events.rb
- !45806 (merged) -
spec/factories/design_management/design_at_version.rb
- !45766 (merged) -
spec/factories/design_management/designs.rb
- !45766 (merged) -
spec/factories/design_management/versions.rb
- !45766 (merged) -
spec/factories/events.rb
- !56691 (merged) -
spec/factories/git_wiki_commit_details.rb
- !56691 (merged) -
spec/factories/gitaly/commit.rb
- !56691 (merged) -
spec/factories/go_module_commits.rb
- !55772 (merged) -
spec/factories/go_module_versions.rb
- !55772 (merged) -
spec/factories/go_modules.rb
- !55772 (merged) -
spec/factories/group_group_links.rb
- !56691 (merged) -
spec/factories/import_export_uploads.rb
- !56691 (merged) -
spec/factories/merge_requests.rb
- !48154 (merged) -
spec/factories/notes.rb
- !52923 (merged) -
spec/factories/packages.rb
- !47395 (merged) -
spec/factories/packages/package_file.rb
- !47395 (merged) -
spec/factories/prometheus_alert.rb
- !45526 (merged) -
spec/factories/resource_label_events.rb
- !45684 (merged) -
spec/factories/resource_milestone_event.rb
- !45684 (merged) -
spec/factories/resource_state_event.rb
- !45684 (merged) -
spec/factories/sent_notifications.rb
- !48153 (merged) -
spec/factories/serverless/domain.rb
- !45587 (merged) -
spec/factories/serverless/domain_cluster.rb
- !45587 (merged) -
spec/factories/terraform/state.rb
- !45587 (merged) -
spec/factories/uploads.rb
- !46393 (merged) -
spec/factories/wiki_pages.rb
- !46393 (merged)
Edited by Peter Leitzen