Skip to content

Fix/keyboard shortcuts modal, fixes #5895

What does this MR do?

Fixes #5895 (moved)

Are there points in the code the reviewer needs to double check?

Appropriate use of $limited-layout-width as max-width for keyboard shortcut modal see code/comment

Why was this MR needed?

Modal was clipping text

Screenshots (if relevant)

Old behavior (large desktop)

Screen_Shot_2018-05-04_at_16.02.36

New behavior (large desktop)

Screen_Shot_2018-05-04_at_16.14.37

New behavior (tablet in portrait, clipped for brevity)

Screen_Shot_2018-05-04_at_16.14.58

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • Has been reviewed by Backend
    • Has been reviewed by Database
  • EE specific content should be in the top level /ee folder
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

#5895 (moved)

Merge request reports

Loading