Skip to content

Reapply !53803 Allow saving repository weights after a storage has been removed - [RUN ALL RSPEC] [RUN AS-IF-FOSS]

James Fargher requested to merge fix_repo_storage_weights_admin_2 into master

What does this MR do?

Reapplies !53803 (merged) that was previously reverted in !55662 (merged) as it broke various background migration specs in master.

This MR has an additional fix in a separate commit to change the default for the hstore field. hstore can only have string keys, but rails will allow symbol keys in memory. This was causing the filtering to fail as the default had symbol keys and the filter expects strings.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by David Fernandez

Merge request reports