Skip to content

Rename vulnerability fingerprints indexes

rossfuhrman requested to merge rename-vuln-fingerprint-indexes into master

What does this MR do?

In this MR, we're just renaming the indexes on the vulnerability_finding_fingerprints.fingerprint_sha256 column in order to make renaming the column easier in a separate follow-up MR. See this thread for more context: !55173 (comment 517418812)

The vulnerability_finding_fingerprints table is not currently in use.

Migration output

click to expand
$ VERSION=20210302212623 rake db:migrate:up
== 20210302212623 RenameVulnFingerprintsIndexes: migrating ====================
-- indexes(:vulnerability_finding_fingerprints)
   -> 0.0029s
-- current_schema()
   -> 0.0001s
-- rename_index(:vulnerability_finding_fingerprints, :idx_vuln_fingerprints_on_occurrences_id_and_fingerprint, :idx_vuln_fingerprints_on_occurrences_id_and_fingerprint_sha256)
   -> 0.0060s
-- indexes(:vulnerability_finding_fingerprints)
   -> 0.0014s
-- current_schema()
   -> 0.0001s
-- rename_index(:vulnerability_finding_fingerprints, :idx_vuln_fingerprints_uniqueness, :idx_vuln_fingerprints_uniqueness_fingerprint_sha256)
   -> 0.0016s
== 20210302212623 RenameVulnFingerprintsIndexes: migrated (0.0162s) ===========

$ VERSION=20210302212623 rake db:migrate:down
== 20210302212623 RenameVulnFingerprintsIndexes: reverting ====================
-- indexes(:vulnerability_finding_fingerprints)
   -> 0.0027s
-- current_schema()
   -> 0.0001s
-- rename_index(:vulnerability_finding_fingerprints, :idx_vuln_fingerprints_on_occurrences_id_and_fingerprint_sha256, :idx_vuln_fingerprints_on_occurrences_id_and_fingerprint)
   -> 0.0062s
-- indexes(:vulnerability_finding_fingerprints)
   -> 0.0014s
-- current_schema()
   -> 0.0001s
-- rename_index(:vulnerability_finding_fingerprints, :idx_vuln_fingerprints_uniqueness_fingerprint_sha256, :idx_vuln_fingerprints_uniqueness)
   -> 0.0015s
== 20210302212623 RenameVulnFingerprintsIndexes: reverted (0.0157s) ===========

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Dmitry Gruzd

Merge request reports