Skip to content

Fix Sidekiq system check for cluster mode

Markus Koller requested to merge 295665-fix-sidekiq-check into master

What does this MR do?

When running with sidekiq-cluster (which is the default now) we have more than one worker process, so the check is changed to either require 0 cluster processes and 1 worker, or 1 cluster process with 1+ workers.

Replaces the original MR !50873 (closed) contributed by @prote.

Fixes #295665 (closed)

Running without a cluster is deprecated and will be removed in %14.0: https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/install/installation.md#using-sidekiq-instead-of-sidekiq-cluster

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Markus Koller

Merge request reports