Simplify notifications dropdown
What does this MR do?
While working on !53260 (merged), I noticed the notifications dropdown was updated to be a vue component, which is great! However, when I updated the notifications to custom and back again, the styles didn't reflect what's in Pajamas (see With icon and split example). So, I wanted to create a separate MR to update this button since it requires more in depth review, separate from the other changes in !53260 (merged).
This change simplifies this component and utilizes the split property as a conditional if isCustomNotification is true.
Screenshots (strongly suggested)
| Before | After |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team