Skip to content

Update project page buttons to conform to design system

Jarek Ostrowski requested to merge 273286-update-project-view-buttons into master

What does this MR do?

Closes #273286 (closed).

Issues that need fixing upstream

  • Star icon svg isn't centered in gitlab-svgs (being fixed in gitlab-svgs#177 (closed))
  • Small button dropdown-icon-only doesn't adjust right padding like the md size buttons do
  • Small dropdown icon only button's icon need to be 16px

Screenshots (strongly suggested)

Before After
Info variant Clone_before Confirm variant and spacing update Screen_Shot_2021-02-18_at_10.34.00_AM
Mobile_clone_before Screen_Shot_2021-02-19_at_4.28.53_PM
History_before Screen_Shot_2021-02-19_at_4.29.54_PM
Screen_Shot_2021-02-18_at_3.41.38_PM Screen_Shot_2021-02-25_at_1.02.46_PM
Screen_Shot_2021-02-18_at_3.42.05_PM Screen_Shot_2021-02-18_at_3.07.48_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #273286 (closed)

Edited by Jarek Ostrowski

Merge request reports