Skip to content

Geo Node Status 2.0 - Loading and Empty States

Zack Cuddy requested to merge 287978_02-geo-beta-loading-empty-state into master

What does this MR do?

This MR breaks off from the UI mega MR: !53090 (closed)
Work towards #287978 (closed)

This MR adds the loading and empty states to the Geo Nodes Beta UI using GitLab UI components.

This change also adds logic to hide the "Add site" button when there are no existing nodes. This is based on an old Geo requirement found here: #9233 (comment 254055641)

How to test

  1. Set up a Geo Primary/Secondary GDK
  2. Fetch the current branch
  3. Activate the Feature Flag on your Primary GDK (:geo_nodes_beta)
  4. Navigate to http://127.0.0.1:3000/admin/geo/nodes_beta
  5. View UI

Screenshots (strongly suggested)

Loading State Empty State
Screenshots Loading_State Screen_Shot_2021-02-25_at_10.34.50_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Zack Cuddy

Merge request reports

Loading