Add new runner build registration metrics [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
This merge request refactors runner build registration metrics add extends them with new ones that are necessary to understand better how the CI/CD builds queuing performs.
Conformity
Issues
Related to #118495 (closed)
Merge request reports
Activity
changed milestone to %13.10
added grouppipeline execution typemaintenance labels
added typefeature label
/cc @ayufan @darbyfrey
added 1 commit
- d33ab4db - Refactor new runner build registration metrics
added backend label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.2 Messages CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 54909 "Add new runner build registration metrics [RUN ALL RSPEC] [RUN AS-IF-FOSS]"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 54909 "Add new runner build registration metrics [RUN ALL RSPEC] [RUN AS-IF-FOSS]"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
You're adding or removing a feature flag, your MR title needs to include [RUN ALL RSPEC] [RUN AS-IF-FOSS]
(we may have updated it automatically for you and started a new MR pipeline) to ensure everything is covered.Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Tiger Watson ( @tigerwnz
) (UTC+13, 12 hours ahead of@grzesiek
)Nick Thomas ( @nick.thomas
) (UTC+0, 1 hour behind@grzesiek
)~feature_flag No reviewer available No maintainer available If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- 5d564c33 - Refactor build registration metrics and add new ones
added 1 commit
- 239ab564 - Add additional metrics related to builds queuing
mentioned in issue #118495 (closed)
mentioned in merge request !54953 (merged)
added rapid action label
mentioned in issue #322712 (closed)
added 242 commits
-
239ab564...6882f4c0 - 241 commits from branch
master
- e849f14b - Add additional metrics related to builds queuing
-
239ab564...6882f4c0 - 241 commits from branch
added 1 commit
- 7478926f - Add additional metrics related to builds queuing
added 1 commit
- 987b4046 - Add additional metrics related to builds queuing
assigned to @ayufan
- Resolved by Grzegorz Bizon
- Resolved by Grzegorz Bizon
- Resolved by Grzegorz Bizon
- Resolved by Grzegorz Bizon
- Resolved by Grzegorz Bizon
- Resolved by Grzegorz Bizon
- Resolved by Grzegorz Bizon
added 1 commit
- 71e44dc9 - Simplify builds queuing metrics and add feature flag
added 1 commit
- c772ea98 - Add a separate histogram for builds queue size
47 71 end 48 72 # rubocop: enable CodeReuse/ActiveRecord 49 73 74 def increment_queue_operation(operation) 75 return unless Feature.enabled?(:gitlab_ci_builds_queuing_metrics, default_enabled: false) I wonder what is the cost of checking a FF vs incrementing a Prometheus counter. @smcgivern do you think it makes sense to add FF in that case?
changed this line in version 10 of the diff
@grzesiek I think the feature flag cost here will (mostly) be shared across the many calls to check this flag in this MR. However, for the increments I think we should be pretty safe anyway - for the other items like queue depth, I think it's a good idea to keep the flag
Thanks @smcgivern! This is what I've done in !54909 (5f8c8203). Let's see how it works once it lands on production :)
added 1 commit
- 5f8c8203 - Remove FF check from CI/CD queue operation metrics
marked the checklist item Code review guidelines as completed
mentioned in commit 8aac62b2
added workflowstaging label
added workflowcanary label and removed workflowstaging label
mentioned in merge request !19517 (closed)
added workflowproduction label and removed workflowcanary label
mentioned in issue #292047 (closed)
added devopsverify label
added rapid actionshift db load from primary label
added releasedcandidate label
mentioned in merge request !56341 (closed)
removed typefeature label
added pipeline:run-all-rspec pipeline:run-as-if-foss labels
mentioned in issue gitlab-org/quality/triage-reports#20613 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20978 (closed)
mentioned in issue gitlab-org/quality/triage-reports#21525 (closed)
mentioned in issue gitlab-org/quality/triage-reports#22029