Skip to content
Snippets Groups Projects

Add new runner build registration metrics [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Merged Grzegorz Bizon requested to merge feature/gb/runner-register-build-metrics into master
1 unresolved thread

What does this MR do?

This merge request refactors runner build registration metrics add extends them with new ones that are necessary to understand better how the CI/CD builds queuing performs.

Conformity

Issues

Related to #118495 (closed)

Edited by Kamil Trzciński

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Kamil Trzciński
  • Grzegorz Bizon added 1 commit

    added 1 commit

    • 71e44dc9 - Simplify builds queuing metrics and add feature flag

    Compare with previous version

  • 🤖 GitLab Bot 🤖 changed title from Add new runner build registration metrics to Add new runner build registration metrics [RUN ALL RSPEC] [RUN AS-IF-FOSS]

    changed title from Add new runner build registration metrics to Add new runner build registration metrics [RUN ALL RSPEC] [RUN AS-IF-FOSS]

  • Grzegorz Bizon added 1 commit

    added 1 commit

    • c772ea98 - Add a separate histogram for builds queue size

    Compare with previous version

  • Grzegorz Bizon resolved all threads

    resolved all threads

  • 47 71 end
    48 72 # rubocop: enable CodeReuse/ActiveRecord
    49 73
    74 def increment_queue_operation(operation)
    75 return unless Feature.enabled?(:gitlab_ci_builds_queuing_metrics, default_enabled: false)
  • Kamil Trzciński approved this merge request

    approved this merge request

  • Grzegorz Bizon added 1 commit

    added 1 commit

    • 5f8c8203 - Remove FF check from CI/CD queue operation metrics

    Compare with previous version

  • Kamil Trzciński resolved all threads

    resolved all threads

  • Kamil Trzciński marked the checklist item Code review guidelines as completed

    marked the checklist item Code review guidelines as completed

  • mentioned in commit 8aac62b2

  • added workflowcanary label and removed workflowstaging label

  • Grzegorz Bizon mentioned in merge request !19517 (closed)

    mentioned in merge request !19517 (closed)

  • added workflowproduction label and removed workflowcanary label

  • Author Maintainer

    This is live on production! So far everything looks good! :rocket:

    queue_metrics_counters

  • Author Maintainer

    It works!

    queue_metrics_counters

    builds_queue_result_counter

  • mentioned in issue #292047 (closed)

  • Grzegorz Bizon mentioned in merge request !56341 (closed)

    mentioned in merge request !56341 (closed)

  • Please register or sign in to reply
    Loading