Skip to content

Move project repository storage classes to namespace

Francisco Javier López (ex-Gitlab) requested to merge 299853-fj-move-project-repository-storage-classes-to-namespace into master

What does this MR do?

This MR is needed to keep the code aligned. According to our guidelines and cops (!51236 (merged)), classes should be namespaced. Related to the repository storage update, we introduced the new classes for groups in a namespace, but there are others, for projects and snippets, that still follow the old naming. So now, we have mixed namespaces in this functionality.

With this MR we start cleaning that up and move everything to a namespace.

Since some of the classes are workers or called inside existing workers, we cannot get rid entirely of these classes, and we need to wait for 14.0 to do that.

In specific we do:

  • Move ProjectRepositoryStorageMoves entity to Projects::RepositoryStorageMoves
  • Copy ProjectRepositoryStorageMoves model to ProjectsRepositoryStorageMoves
    • Remove all the logic from ProjectRepositoryStorageMoves
    • Make ProjectRepositoryStorageMoves a subclass of Projects::RepositoryStorageMoves
  • Copy ProjectUpdateRepositoryStorageWorker to Projects::UpdateRepositoryStorageWorker
    • Remove all the logic from ProjectUpdateRepositoryStorageWorker
    • Make ProjectUpdateRepositoryStorageWorker a subclass of Projects::UpdateRepositoryStorageWorker
  • Copy ProjectScheduleBulkRepositoryShardMovesWorker to Projects::ScheduleBulkRepositoryShardMovesWorker
    • Remove all the logic from ProjectScheduleBulkRepositoryShardMovesWorker
    • Make ProjectScheduleBulkRepositoryShardMovesWorker a subclass of Projects::ScheduleBulkRepositoryShardMovesWorker
  • Replace all references to the old classes with the new ones.

Does this MR meet the acceptance criteria?

Conformity

Related to #299853 (closed)

Edited by Francisco Javier López (ex-Gitlab)

Merge request reports