Move ProjectRepositoryStorageMove and SnippetRepositoryStorageMove classes (and workers) to namespace
After !51236 (merged), we're enforcing classes to be namespaced.
We're doing so for groups in &5166 (closed) but we already have the classes ProjectRepositoryStorageMove
and SnippetRepositoryStorageMove
merged and it's weird to have this discrepancy.
We need to move both classes inside the Projects
and Snippets
namespaces.
We also need to move the following workers:
- ProjectUpdateRepositoryStorageWorker
- ProjectScheduleBulkRepositoryShardMovesWorker
- SnippetUpdateRepositoryStorageWorker
- SnippetScheduleBulkRepositoryShardMovesWorker
Nevertheless, moving workers is a little bit complicated. According to our docs, we can only do so in major versions(https://docs.gitlab.com/ee/development/sidekiq_style_guide.html#removing-workers) and, besides, there can be jobs enqueued calling me.
Therefore we need to do the following:
- Create the new classes keeping the old workers
- Change the old workers to call the new ones that are inside namespaces
- In 14.0, remove the old workers. (We need to create an issue for 14.0 to remember, see
GitGarbageCollectWorker
comment in code and issue).
Edited by Francisco Javier López (ex-Gitlab)