Remove FF ci_rules_variables [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
This MR removes the feature flag ci_rules_variables
. It's already enabled by default (!50501 (merged)).
(This MR does not need a changelog because the changelog was added when enabling the FF by default.)
- Feature issue: #209864 (closed)
- Introduced in: !48752 (merged)
- Rollout issue: #289803 (closed)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.10
added backend devopsverify feature flag grouppipeline authoring sectionops typemaintenance workflowin review + 1 deleted label
added typefeature label
added documentation label
3 Messages 📖 This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. 📖 CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 54716 "Remove FF ci_rules_variables [RUN ALL RSPEC] [RUN AS-IF-FOSS]"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 54716 "Remove FF ci_rules_variables [RUN ALL RSPEC] [RUN AS-IF-FOSS]"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
📖 You're adding or removing a feature flag, your MR title needs to include [RUN ALL RSPEC] [RUN AS-IF-FOSS]
(we may have updated it automatically for you and started a new MR pipeline) to ensure everything is covered.Documentation review
The following files require a review from a technical writer:
doc/ci/yaml/README.md
The review does not need to block merging this merge request. See the:
- Technical Writers assignments for the appropriate technical writer for this review.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Nicolas Dular ( @nicolasdular
) (UTC+1, 2 hours behind@furkanayhan
)Stan Hu ( @stanhu
) (UTC-8, 11 hours behind@furkanayhan
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖@marcel.amirault Can you please do the documentation review?
assigned to @marcel.amirault
removed workflowin review label
added Technical Writing docsfeature twfinished labels
@furkanayhan Thanks, LGTM!
🚀 unassigned @marcel.amirault
@caalberts Can you please do the first review?
assigned to @caalberts
LGTM.
@stanhu Could you help with maintainer review please?
assigned to @stanhu
unassigned @caalberts
@stanhu Can you please set MWPS?
🙏 enabled an automatic merge when the pipeline for ff1e8ec7 succeeds
mentioned in commit 559c5148
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
removed typefeature label
added pipeline:run-all-rspec pipeline:run-as-if-foss labels
added Category:Pipeline Composition label