Make empty state copy aware of applied filters in Epics list and Roadmap view
What does this MR do?
Makes empty state view subtext aware of filters applied on the page. This MR makes the behaviour consistent for Epics list page and Epic Roadmap page. This MR is follow-up of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5417.
Screenshots
Default Empty State
Epics List | Epic Roadmap |
---|---|
![]() |
![]() |
Filtered Search Empty State
Epics List | Epic Roadmap |
---|---|
![]() |
![]() |
Epic Roadmap Empty State (when no epics are in timeframe)
Does this MR meet the acceptance criteria?
[ ] Changelog entry added, if necessary[ ] Documentation created/updated[ ] API support added-
Tests added for this feature/bug - Review
-
Has been reviewed by UX -
Has been reviewed by Frontend [ ] Has been reviewed by Backend[ ] Has been reviewed by Database
-
-
EE specific content should be in the top level /ee
folder -
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together -
Internationalization required/considered [ ] If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan[ ] End-to-end tests pass (package-qa
manual pipeline job)
What are the relevant issue numbers?
Merge request reports
Activity
assigned to @pedroms
added 8 commits
- 02eb6a43 - Include URL query param in epics path when params are present
- cfc19677 - Add changelog entry
- 3070a1b9 - Group Roadmap Spec
- cccd8a90 - Show correct copy on page based on search params presence
- f27c4bfd - Pass on search params presence flag to roadmap app
- 2194a56e - Use `hasFiltersApplied` during app init
- c24b0b81 - Pass `hasFiltersApplied` prop on component
- f3b0e9ee - Show correct copy on view based on `hasFiltersApplied` prop
Toggle commit listadded 249 commits
-
f3b0e9ee...4a56c554 - 244 commits from branch
master
- b0481742 - Show correct copy on page based on search params presence
- a690d3bc - Pass on search params presence flag to roadmap app
- f3307fdb - Use `hasFiltersApplied` during app init
- e9d29303 - Pass `hasFiltersApplied` prop on component
- 1f1bb0c9 - Show correct copy on view based on `hasFiltersApplied` prop
Toggle commit list-
f3b0e9ee...4a56c554 - 244 commits from branch
- Resolved by Kushal Pandya
- Resolved by Kushal Pandya
@kushalpandya in the Default Empty State, the epics list should look similar to the epics roadmap: no tab bar, no search bar, and the new button should be below the empty state text.
- Resolved by Kushal Pandya
@kushalpandya if possible, the “Epic Roadmap Empty State (when no epics are in timeframe)” should be the same as the “Epic Roadmap Default Empty State”:
- No search bar
- Title:
The roadmap shows the progress of your epics along a timeline
- New epic and view list button below the empty state text
assigned to @kushalpandya
added 133 commits
-
1f1bb0c9...15396b1a - 127 commits from branch
master
- 256ba5b3 - Show correct copy on page based on search params presence
- aa30836c - Pass on search params presence flag to roadmap app
- eb336e28 - Use `hasFiltersApplied` during app init
- 8b50e3e7 - Pass `hasFiltersApplied` prop on component
- 1ecaa9fc - Show correct copy on view based on `hasFiltersApplied` prop, add actions
- e7eee178 - Show Epic searchbar and actions only when Epics are present in the Group
Toggle commit list-
1f1bb0c9...15396b1a - 127 commits from branch
added 1 commit
- 41f35d1c - Show Epic searchbar and actions only when Epics are present in the Group
@pedroms Can you review once more please.
assigned to @pedroms
@kushalpandya thanks, LGTM!
assigned to @kushalpandya
assigned to @filipa
marked the checklist item Conform by the merge request performance guides as completed
marked the checklist item Conform by the style guides as completed
marked the checklist item Squashed related commits together as completed
- Resolved by Kushal Pandya
- Resolved by Kushal Pandya
@kushalpandya code LGTM, just a very small nitpick code wise. I do have a question regarding copy, but could be just me
assigned to @kushalpandya
assigned to @pedroms
assigned to @kushalpandya
added 379 commits
-
a7be8636...d5b77d24 - 373 commits from branch
master
- 44a45184 - Show correct copy on page based on search params presence
- 998a9691 - Pass on search params presence flag to roadmap app
- 1dff121f - Use `hasFiltersApplied` during app init
- c94dc098 - Pass `hasFiltersApplied` prop on component
- 14ad4429 - Show correct copy on view based on `hasFiltersApplied` prop, add actions
- 037e7241 - Show Epic searchbar and actions only when Epics are present in the Group
Toggle commit list-
a7be8636...d5b77d24 - 373 commits from branch
@filipa I have addressed one unresolved discussion. Feel free to set MWPS on this.
assigned to @filipa
- Resolved by Kushal Pandya
mentioned in commit 7c3349ab
mentioned in issue gitlab-org/release/tasks#197 (closed)
added Enterprise Edition label
added Category:Portfolio Management label