Skip to content
Snippets Groups Projects

Make empty state copy aware of applied filters in Epics list and Roadmap view

Merged Kushal Pandya requested to merge 3729-fix-epics-roadmap-empty-states into master
All threads resolved!

What does this MR do?

Makes empty state view subtext aware of filters applied on the page. This MR makes the behaviour consistent for Epics list page and Epic Roadmap page. This MR is follow-up of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5417.

Screenshots

Default Empty State

Epics List Epic Roadmap
Screen_Shot_2018-04-30_at_2.59.48_PM Screen_Shot_2018-04-30_at_3.00.27_PM

Filtered Search Empty State

Epics List Epic Roadmap
Screen_Shot_2018-04-30_at_3.08.06_PM Screen_Shot_2018-04-30_at_3.08.39_PM

Epic Roadmap Empty State (when no epics are in timeframe)

Screen_Shot_2018-04-30_at_3.09.57_PM

Does this MR meet the acceptance criteria?

  • [ ] Changelog entry added, if necessary
  • [ ] Documentation created/updated
  • [ ] API support added
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • [ ] Has been reviewed by Backend
    • [ ] Has been reviewed by Database
  • EE specific content should be in the top level /ee folder
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered
  • [ ] If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • [ ] End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

#3729 (closed)

Edited by Filipa Lacerda

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Kushal Pandya

      @kushalpandya if possible, the “Epic Roadmap Empty State (when no epics are in timeframe)” should be the same as the “Epic Roadmap Default Empty State”:

      • No search bar
      • Title: The roadmap shows the progress of your epics along a timeline
      • New epic and view list button below the empty state text
  • Kushal Pandya added 133 commits

    added 133 commits

    • 1f1bb0c9...15396b1a - 127 commits from branch master
    • 256ba5b3 - Show correct copy on page based on search params presence
    • aa30836c - Pass on search params presence flag to roadmap app
    • eb336e28 - Use `hasFiltersApplied` during app init
    • 8b50e3e7 - Pass `hasFiltersApplied` prop on component
    • 1ecaa9fc - Show correct copy on view based on `hasFiltersApplied` prop, add actions
    • e7eee178 - Show Epic searchbar and actions only when Epics are present in the Group

    Compare with previous version

  • Kushal Pandya added 1 commit

    added 1 commit

    • 41f35d1c - Show Epic searchbar and actions only when Epics are present in the Group

    Compare with previous version

  • Kushal Pandya changed the description

    changed the description

  • @pedroms Can you review once more please. :slight_smile:

  • assigned to @pedroms

  • Pedro Moreira da Silva resolved all discussions

    resolved all discussions

  • Pedro Moreira da Silva marked the checklist item Has been reviewed by UX as completed

    marked the checklist item Has been reviewed by UX as completed

  • Kushal Pandya changed the description

    changed the description

  • Kushal Pandya resolved all discussions

    resolved all discussions

  • @pedroms Thanks for reviewing! :heart:

    @filipa Can you review frontend changes please? :slight_smile:

  • assigned to @filipa

  • Kushal Pandya marked the checklist item Tests added for this feature/bug as completed

    marked the checklist item Tests added for this feature/bug as completed

  • Kushal Pandya marked the checklist item EE specific content should be in the top level /ee folder as completed

    marked the checklist item EE specific content should be in the top level /ee folder as completed

  • Kushal Pandya marked the checklist item Conform by the merge request performance guides as completed

    marked the checklist item Conform by the merge request performance guides as completed

  • Kushal Pandya marked the checklist item Conform by the style guides as completed

    marked the checklist item Conform by the style guides as completed

  • Kushal Pandya marked the checklist item Squashed related commits together as completed

    marked the checklist item Squashed related commits together as completed

  • Kushal Pandya marked the checklist item Internationalization required/considered as completed

    marked the checklist item Internationalization required/considered as completed

  • @kushalpandya code LGTM, just a very small nitpick code wise. I do have a question regarding copy, but could be just me

  • Kushal Pandya added 2 commits

    added 2 commits

    • 7d5e3b13 - Show correct copy on view based on `hasFiltersApplied` prop, add actions
    • a7be8636 - Show Epic searchbar and actions only when Epics are present in the Group

    Compare with previous version

  • @filipa Thanks for review! I've updated this MR to resolve one discussion around button classes.

    @pedroms One open discussion waiting for your response. :slight_smile:

  • assigned to @pedroms

  • Kushal Pandya added 379 commits

    added 379 commits

    • a7be8636...d5b77d24 - 373 commits from branch master
    • 44a45184 - Show correct copy on page based on search params presence
    • 998a9691 - Pass on search params presence flag to roadmap app
    • 1dff121f - Use `hasFiltersApplied` during app init
    • c94dc098 - Pass `hasFiltersApplied` prop on component
    • 14ad4429 - Show correct copy on view based on `hasFiltersApplied` prop, add actions
    • 037e7241 - Show Epic searchbar and actions only when Epics are present in the Group

    Compare with previous version

  • Kushal Pandya resolved all discussions

    resolved all discussions

  • @filipa I have addressed one unresolved discussion. Feel free to set MWPS on this. :slight_smile:

  • assigned to @filipa

  • Filipa Lacerda
  • Filipa Lacerda resolved all discussions

    resolved all discussions

  • Filipa Lacerda approved this merge request

    approved this merge request

  • Filipa Lacerda marked the checklist item Has been reviewed by Frontend as completed

    marked the checklist item Has been reviewed by Frontend as completed

  • Filipa Lacerda mentioned in commit 7c3349ab

    mentioned in commit 7c3349ab

  • Kushal Pandya resolved all discussions

    resolved all discussions

  • Please register or sign in to reply
    Loading