Skip to content
Snippets Groups Projects

Restore missing scrollbar on boards

Merged Simon Knox requested to merge psi-board-scroll into master
All threads resolved!

What does this MR do?

Fix bug introduced in !53690 (merged)

When on boards page, sometimes the horizontal scrollbar is hidden below the bottom of the page and not clickable. This happens if the filter bar has enough items that it has a scrollbar, or if there is a flash message displayed.

We re-add overflow-auto to the body. This does mean we have double scrollbars on the right side again, will address this in #322086 (closed).

before after
Screen_Shot_2021-02-19_at_9.45.09_am Screen_Shot_2021-02-19_at_9.44.50_am
Screen_Shot_2021-02-19_at_9.45.41_am Screen_Shot_2021-02-19_at_9.45.54_am

Does this MR meet the acceptance criteria?

Conformity

Edited by Simon Knox

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 1 Warning
    You've made some app changes, but didn't add any tests.
    That's OK as long as you're refactoring existing code,
    but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.

    Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    Category Reviewer Maintainer
    backend Erick Bajao (@iamricecake) (UTC+8, 3 hours behind @psimyn) Etienne Baqué (@ebaque) (UTC+3, 8 hours behind @psimyn)

    If needed, you can retry the danger-review job that generated this comment.

    Generated by 🚫 Danger

    Edited by 🤖 GitLab Bot 🤖
  • Author Maintainer

    @sstern if you would kindly review

  • assigned to @sstern

  • Author Maintainer

    this should probably be ~"Pick into 13.9" as it can break boards for people without a trackpad

  • Scott Stern approved this merge request

    approved this merge request

  • unassigned @sstern

  • Author Maintainer

    @oregand would you please push the button

  • assigned to @oregand

  • David O'Regan resolved all threads

    resolved all threads

  • David O'Regan added 1 commit

    added 1 commit

    • dbdc766d - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • David O'Regan resolved all threads

    resolved all threads

  • David O'Regan added 1 commit

    added 1 commit

    • dec924ae - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • David O'Regan added 1 deleted label

    added 1 deleted label

  • David O'Regan approved this merge request

    approved this merge request

  • David O'Regan enabled an automatic merge when the pipeline for 073e61bf succeeds

    enabled an automatic merge when the pipeline for 073e61bf succeeds

  • Simon Knox changed the description

    changed the description

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 61a32e5e and 9d1a44d6

    Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.18 MB 3.18 MB - 0.0 %
    mainChunk 1.96 MB 1.96 MB - 0.0 %

    Note: We do not have exact data for 61a32e5e. So we have used data from: 190f86b5.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by 🚫 Danger

    Edited by 🤖 GitLab Bot 🤖
  • Setting label groupproject management based on @psimyn's group.

  • David O'Regan aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • David O'Regan added 270 commits

    added 270 commits

    Compare with previous version

  • David O'Regan enabled an automatic merge when the pipeline for 0b910c72 succeeds

    enabled an automatic merge when the pipeline for 0b910c72 succeeds

  • merged

  • David O'Regan mentioned in commit bb7df266

    mentioned in commit bb7df266

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • GitLab Release Tools Bot picked the changes into the branch 13-9-stable-ee-patch-1 with commit c4e55f6a

    picked the changes into the branch 13-9-stable-ee-patch-1 with commit c4e55f6a

  • Automatically picked into !54919 (merged), will merge into 13-9-stable-ee ready for 13.9.1-ee.

  • David O'Regan mentioned in commit c4e55f6a

    mentioned in commit c4e55f6a

  • GitLab Release Tools Bot removed 1 deleted label

    removed 1 deleted label

  • mentioned in merge request !54919 (merged)

  • Please register or sign in to reply
    Loading