Restore missing scrollbar on boards
What does this MR do?
Fix bug introduced in !53690 (merged)
When on boards page, sometimes the horizontal scrollbar is hidden below the bottom of the page and not clickable. This happens if the filter bar has enough items that it has a scrollbar, or if there is a flash message displayed.
We re-add overflow-auto to the body. This does mean we have double scrollbars on the right side again, will address this in #322086 (closed).
before | after |
---|---|
![]() |
![]() |
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
Merge request reports
Activity
changed milestone to %13.9
added boards devopsplan frontend typebug labels
added backend label
- Resolved by David O'Regan
1 Warning ⚠ You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Erick Bajao ( @iamricecake
) (UTC+8, 3 hours behind@psimyn
)Etienne Baqué ( @ebaque
) (UTC+3, 8 hours behind@psimyn
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖@sstern if you would kindly review
assigned to @sstern
unassigned @sstern
@oregand would you please push the button
assigned to @oregand
- Resolved by David O'Regan
enabled an automatic merge when the pipeline for 073e61bf succeeds
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 61a32e5e and 9d1a44d6
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.18 MB 3.18 MB - 0.0 % mainChunk 1.96 MB 1.96 MB - 0.0 %
Note: We do not have exact data for 61a32e5e. So we have used data from: 190f86b5.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖Setting label groupproject management based on
@psimyn
's group.added groupproject management label
added sectiondev label
added 270 commits
-
dec924ae...61a32e5e - 267 commits from branch
master
- fad135e7 - Restore missing scrollbar on boards
- 4374c0b9 - Apply 1 suggestion(s) to 1 file(s)
- 9d1a44d6 - Apply 1 suggestion(s) to 1 file(s)
Toggle commit list-
dec924ae...61a32e5e - 267 commits from branch
enabled an automatic merge when the pipeline for 0b910c72 succeeds
mentioned in commit bb7df266
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
picked the changes into the branch
13-9-stable-ee-patch-1
with commit c4e55f6aAutomatically picked into !54919 (merged), will merge into
13-9-stable-ee
ready for13.9.1-ee
.mentioned in commit c4e55f6a
mentioned in merge request !54919 (merged)
added releasedcandidate label
added Category:Team Planning label