Skip to content

Add spec for failing Jira issue transitions

Markus Koller requested to merge 16119-fix-custom-transition-sequence into master

What does this MR do?

I thought I had made a mistake in !53760 (merged) by moving the error handling from transition_issue to transition_issue_to_id, and letting transition_issue continue with the subsequent transition IDs, instead of failing.

But then I remembered I also switched from .each to .all?, so we're still failing correctly: https://gitlab.com/gitlab-org/gitlab/blob/afd9550a511586064fd09e61aa0b8ea666be58d7/app/models/project_services/jira_service.rb#L271

In any case, this behaviour should be covered by a spec. 😅

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #16119 (closed)

Merge request reports