You need to sign in or sign up before continuing.
Fix `NULL` insert attempts for `missing_on_primary`
Compare changes
Files
2+ 6
− 3
@@ -106,10 +106,13 @@ module Gitlab
When a file download response is 404 without a response body, or a non-200-or-404, then we currently attempt to save NULL
for missing_on_primary
. This errors due to the not null constraint on the field.
The only source of artifact 404s that are not missing-on-primary that I am aware of is: artifacts that have been migrated to object storage before the secondary has synced them.
This will generate Sentry errors and errors in geo.log.
Each sidekiq job will retry 3 times before disappearing.
With the bug fixed, the artifact sync will be tracked as failed, and then periodically retried until MigratedLocalFilesCleanUpWorker
deletes the tracking record.
TL;DR the impact is noise in Sentry and geo.log.
/ee
folderpackage-qa
manual pipeline job)Resolves https://gitlab.com/gitlab-org/gitlab-ee/issues/5727