Skip to content

Cloud License Activation Form View

Jake Burden requested to merge cloud-license-subscription-view into master

What does this MR do?

This MR addresses https://gitlab.com/gitlab-org/gitlab/-/issues/273023 and:

  • creates the VUE Components to populate the Cloud License Subscription Activation Form
  • creates an empty Subscription Details Component
  • add VueApollo integration to perform the activation
  • adds tests and related utils

How to test

  • In your Rails console, activate Cloud License by using
ApplicationSetting.current.update(cloud_license_enabled: true)

Screenshots (strongly suggested)

Subscription Activation Form Subscription Activation Form Filled Subscription Activation Form Requried Subscription Details
Screenshot_2021-03-01_at_10.18.42 Screenshot_2021-03-01_at_10.18.51 Screenshot_2021-03-01_at_10.18.46
Video (fake activation number)
Screen_Recording_2021-03-01_at_10.19.04

Does this MR meet the acceptance criteria?

As defined here, in this MR the application is expected to behave:

  • when a valid activation code is provided, it will show an empty Subscription Details view
  • when an invalid activation code is provided... the case will be addressed with this Issue
  • when a general error occurs... the case will be addressed with this Issue

Given this view is only visible upon activation of the feature, neither a FF nor a changelog are required.

EDIT: as per the discussion below, the Subscription Details part has been removed.

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Angelo Gulina

Merge request reports