Add database sourced aggregated metric [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
This MR aims to wrap remaining pieces to complete implementation of &5227 (closed), in order to achieve this it introduces following changes:
- It adds first database sourced aggregated metric definition - this was done, to provide real use case for validation all changes in production env, as well as to discover some minor problems, with underlying implementation of aggregated metrics for database sourced metrics feature.
- It splits aggregated metrics definition for CE and EE, to avoid raising errors when metric in not present in EE
Relates to #300411 (closed) as it is impossible to verify if feature works correctly without any database sourced aggregate defined
Does this MR meet the acceptance criteria?
Conformity
Merge request reports
Activity
added backend devopsgrowth groupanalytics instrumentation sectiongrowth labels
1 Warning For the following files, a review from the Data team and Product Intelligence team is recommended
Please check the product intelligence guide and reach out to @gitlab-org/growth/product-intelligence/engineers group for a review.ee/lib/gitlab/usage_data_counters/aggregated_metrics/common.yml
lib/gitlab/usage_data_counters/aggregated_metrics/common.yml
2 Messages This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 53854 "Add database sourced aggregated metric [RUN ALL RSPEC] [RUN AS-IF-FOSS]"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 53854 "Add database sourced aggregated metric [RUN ALL RSPEC] [RUN AS-IF-FOSS]"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Documentation review
The following files require a review from a technical writer:
doc/development/usage_ping/index.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Rubén Dávila ( @rdavila
) (UTC-5, 6 hours behind@mikolaj_wawrzyniak
)Alex Kalderimis ( @alexkalderimis
) (UTC+0, 1 hour behind@mikolaj_wawrzyniak
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖added product intelligence product intelligencereview pending labels
added 864 commits
-
004d4bfa...224891b3 - 860 commits from branch
master
- 473a57f7 - Update Aggregated Metrics documentation
- 56514cb4 - Revisions for tone, style, and word wrapping
- 4c8edbdf - Fix typo in aggregated metrics documentation
- 519ab358 - Add database sourced aggregated metric
Toggle commit list-
004d4bfa...224891b3 - 860 commits from branch
- Resolved by Alper Akgun
added documentation label
marked the checklist item Documentation (if required) as completed
- Resolved by Alper Akgun