Packages and Registries settings: refactor to gl-alert
What does this MR do?
This MR refactors the code introduced in !52472 (merged) to use gl-alert
instead of createFlash
In addition, we are adjusting the code behavior to:
- Show a warning alert when the request fails
- Show a success toast when the requests succeeds
- If a warning alert is shown and the request suceeds, we remove the warning alert
This work is still behind feature flag:
Feature flag rollout issue: #297371 (closed)
Screencapture (strongly suggested)
PackageSettingsUseToastForSuccess
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #301022 (closed)
Edited by Nicolò Maria Mezzopera