Skip to content

Add maven duplicates settings to package group settings

What does this MR do?

This MR adds the necessary form fields to the Packages and Registries group settings page.

note: we are using an optimistic response here, so we assume that the call to the backend will be succesful and we update the UI before the API call is successfull

This whole work is behind feature flag

The Plan

Feature flag rollout issue: #297371 (closed)

Step MR
Add new page and menu entry + feature flag !51460 (merged)
Add basic components + queries and mutations :!51883 (merged)
Wire the new UI and UX review 👈 you are here!
Document + remove feature flag TBD

Screenshots (strongly suggested)

Disabled Enabled
Screenshot_2021-01-26_at_12.39.25 Screenshot_2021-01-29_at_11.56.39

Screencapture

MavenSettingsErrorHandling

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #296895 (closed)

Edited by Nicolò Maria Mezzopera

Merge request reports