Skip to content

Separate sections in user settings pages layout

Enrique Alcántara requested to merge refactor-user-settings-page-layout into master

What does this MR do?

It refactors four User Settings pages that have more than one content section so each section is wrapped by a container div. We could call this container div, a explicit delimiter between sections. Before this refactoring, sections were only visually separated using Bootstrap grid framework.

This is part of the effort to add search to settings pages (See !52700 (closed))

Other merge requests

Screenshots (strongly suggested)

These changes does not have user-facing changes as demonstrated by the screenshots

Page Before After
Account Screenshot_2021-02-01_Account___User_Settings_-_Before Screenshot_2021-02-01_Account___User_Settings_-_After
Profile Screenshot_2021-02-01_Edit_Profile___User_Settings_-_Before Screenshot_2021-02-01_Edit_Profile___User_Settings_-_After
Access Tokens Screenshot_2021-02-01_Personal_Access_Tokens___User_Settings_-_After Screenshot_2021-02-01_Personal_Access_Tokens___User_Settings_-_Before
Preferences Screenshot_2021-02-01_Preferences___User_Settings_-_After Screenshot_2021-02-01_Preferences___User_Settings_-_Before

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Paul Slaughter

Merge request reports