Skip to content

Fix flashy search box when loading a settings page

Enrique Alcántara requested to merge settings-search-box-placeholder into master

What does this MR do?

This is a UX improvement that displays a search box placeholder while the Search Settings Vue application loads. The intention of this placeholder is creating the perception that the search box loads immediately.

Screenshots (strongly suggested)

Before After
2021-01-28_16.17.36 2021-01-28_16.16.57

How to test?

  • Enable the search_settings_in_page feature flag
  • Open the General Settings page for a project in your local environment, i.e. http://localhost:3000/h5bp/html5-boilerplate/edit

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Paul Slaughter

Merge request reports