Resolve "Iterations dropdown component is not consistent with gitlab/ui"
What does this MR do?
Resolves:
-
#300248 (closed) Iterations dropdown component is not consistent with gitlab/ui
-
#300371 (closed) Display a spinner while loading/fetching data in iteration dropdown
-
#220381 (closed) Do not load iterations until the user shows intention they want to open the dropdown.
-
#220379 (closed) When there are no iterations on a group, show the user in the dropdown
Also improves/fixes the spec by using mock apollo client.
Screenshots (strongly suggested)
| Before | After |
|---|---|
 |
 |
 |
 |
 |
 |
 |
 |
 |
 |
(displays "No iterations found" by default - relates to #220379 (closed)) 
|
|
| (now shows a loading spinner) Screen_Recording_2021-02-01_at_10.14.09_AM | |
| Screen_Recording_2021-02-02_at_9.35.35_AM | |
(hovering on edit button turns the entire edit text blue including the underline)
|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by euko