Skip to content

Make Danger warn when a feature flag is removed and title doesn't include required flags [RUN ALL RSPEC] [RUN AS-IF-FOSS]

What does this MR do?

Make Danger warn when a feature flag is removed and title doesn't include required flags [RUN ALL RSPEC] [RUN AS-IF-FOSS].

Additionally, Danger will update the MR title so that it includes [RUN ALL RSPEC] [RUN AS-IF-FOSS] and start a new MR pipeline.

Screenshots (strongly suggested)

1. Danger updates the MR title

Screen_Shot_2021-01-28_at_18.59.36


2. Danger starts a new MR pipeline

Screen_Shot_2021-01-28_at_18.59.48


3. Danger leaves an information message

Screen_Shot_2021-01-28_at_18.59.24

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #299463 (closed)

Edited by Rémy Coutable

Merge request reports