Skip to content

Fix pages migration deadlock

What does this MR do?

Fixes #300123 (closed)

Fix is taken from https://guides.rubyonrails.org/threading_and_code_execution.html#permit-concurrent-loads

I can't claim that I understand the underlying behavior, but the deadlock we're catching here looks exactly as described. And in other places where we use Rails.application.executor.wrap, we also use ActiveSupport::Dependencies.interlock.permit_concurrent_loads.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński

Merge request reports