Refactor Ci::Build#group_name [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
This merge request removes matrix brackets : [...]
and parallelization digits X Y
/ X/Y
/ X\Y
from the end of build names only before grouping, leaving prefix and infix matches intact.
Examples
See the new specs added for the changes, they are most of the previously used pairs but with some changes.
Does this MR meet the acceptance criteria?
Conformity
Changelog entry-
Documentation (if required)~~ -
Code review guidelines -
Merge request performance guidelines -
Style guides Database guidesSeparation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. Tested in all supported browsersInformed Infrastructure department of a default or new setting change, if applicable per definition of done
Merge request reports
Activity
changed milestone to %13.9
added backend label
1 Warning The merge request title must contain at least 3 words. For more information, take a look at our Commit message guidelines. 3 Messages This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 52644 "Refactor Ci::Build#group_name [RUN ALL RSPEC] [RUN AS-IF-FOSS]"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 52644 "Refactor Ci::Build#group_name [RUN ALL RSPEC] [RUN AS-IF-FOSS]"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
You're adding or removing a feature flag, your MR title needs to include [RUN ALL RSPEC] [RUN AS-IF-FOSS]
(we may have updated it automatically for you and started a new MR pipeline) to ensure everything is covered.Documentation review
The following files require a review from a technical writer:
doc/ci/jobs/index.md
The review does not need to block merging this merge request. See the:
- Technical Writers assignments for the appropriate technical writer for this review.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Terri Chu ( @terrichu
) (UTC-5, same timezone as@drew
)Patrick Bajao ( @patrickbajao
) (UTC+8, 13 hours ahead of@drew
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖added devopsverify grouppipeline security typebug labels and removed backend label
added backend label
marked the checklist item Changelog entry as completed
marked the checklist item Style guides as completed
- Resolved by drew stachon
@lauraMon Would you mind reviewing this? I saw your work on !51157 (merged) and figure you have all the context for it.
mentioned in issue #207485 (closed)
- Resolved by drew stachon
added 289 commits
-
3b90f419...7ca65803 - 287 commits from branch
master
- 608ac3c8 - Support more build group names
- f7950e36 - Remove unnecessary prefix match
-
3b90f419...7ca65803 - 287 commits from branch