Handle unreachable ES host in settings check
requested to merge 299991-opening-admin-settings-page-results-in-the-error-500-if-localhost-cannot-be-accessed-on into master
What does this MR do?
Related to #299991 (closed)
Fixes an error if Elasticsearch is unreachable when checking if the Elasticsearch client is available using the ping
method. The ping method only handles a types of errors so I added a more generic rescue (which was present previously and replaced another MR). I had trouble reproducing this manually so I added a spec which did fail and now passes.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Terri Chu