Handle unreachable ES host in settings check
What does this MR do?
Related to #299991 (closed)
Fixes an error if Elasticsearch is unreachable when checking if the Elasticsearch client is available using the ping
method. The ping method only handles a types of errors so I added a more generic rescue (which was present previously and replaced another MR). I had trouble reproducing this manually so I added a spec which did fail and now passes.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
added 1 commit
- 3a161659 - Handle network unreachable error in ES settings check
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Vijay Hawoldar ( @vij
) (UTC+0, 5 hours ahead of@terrichu
)James Lopez ( @jameslopez
) (UTC+1, 6 hours ahead of@terrichu
)frontend Tristan Read ( @tristan.read
) (UTC+13, 18 hours ahead of@terrichu
)David O'Regan ( @oregand
) (UTC+0, 5 hours ahead of@terrichu
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖marked the checklist item Changelog entry as completed
added workflowin dev label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 3cae40d9 and e9b6d53d
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.08 MB 3.08 MB - 0.0 % mainChunk 1.89 MB 1.89 MB - 0.0 %
Note: We do not have exact data for 3cae40d9. So we have used data from: 67d0cc39.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Brandon Labuschagne
assigned to @rob.hunt
- Resolved by Kamil Trzciński
assigned to @dgruzd
- Resolved by Kamil Trzciński
changed milestone to %13.9
assigned to @blabuschagne and unassigned @rob.hunt
mentioned in issue gitlab-com/www-gitlab-com#10293 (closed)
unassigned @ayufan
added 1 commit
- e9b6d53d - fixup! Handle network unreachable error in ES settings check
marked this merge request as draft from e9b6d53d
mentioned in issue #299980 (closed)
assigned to @ayufan
Setting label(s) Category:Global Search sectionenablement based on groupglobal search.
added Category:Global Search sectioncore platform labels
unassigned @blabuschagne
@terrichu It is great :)
mentioned in commit 1cec26c7
added workflowstaging label and removed workflowin dev label
added workflowcanary label and removed workflowstaging label
added workflowstaging label and removed workflowcanary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
@terrichu This merge request could not automatically be picked into
13-8-stable-ee
for13.8.3-ee
and will need manual intervention.Create a new merge request targeting the
13-8-stable-ee-patch-3
branch in order to have this MR included in !53357 (merged).Please follow the Process for Developers.
Backported in !53399 (merged)
mentioned in merge request !53357 (merged)
The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/251592089 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/251608706 downstream.The
Trigger:qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/251608706 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/251634246 downstream.The
gitlab-qa
downstream pipeline failed!💥 .
added releasedcandidate label
mentioned in issue #322499 (closed)
mentioned in issue gitlab-com/www-gitlab-com#6765 (closed)
added devopsdata stores label and removed devopssystems label