Skip to content
Snippets Groups Projects

Do not use attributes_for in RemoveDuplicateCsFindings spec

Merged Michał Zając requested to merge 299420-refactor-remove_duplicate_cs_findings_spec into master
All threads resolved!

What does this MR do?

Removes usage of attributes_for in X specs. With !52182 (merged) we banned attributes_for in migration specs. This refactors one of the offending migrations.

Related to #299420.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #299420

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading