Rewrite offenders using `attributes_for` in migration specs
The following discussion from !52182 (merged) should be addressed:
-
@godfat-gitlab started a discussion: We'll need to remove all of
# rubocop: disable RSpec/FactoriesInMigrationSpecs
Current files with offenses:
-
spec/lib/gitlab/background_migration/legacy_uploads_migrator_spec.rb -
spec/lib/gitlab/background_migration/legacy_upload_mover_spec.rb -
spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb -
spec/lib/gitlab/background_migration/migrate_to_hashed_storage_spec.rb(removed in !74001 (merged)) -
ee/spec/lib/ee/gitlab/background_migration/update_location_fingerprint_for_container_scanning_findings_spec.rb -
ee/spec/lib/ee/gitlab/background_migration/migrate_security_scans_spec.rb(removed in !74001 (merged)) -
ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_in_batch_spec.rb -
ee/spec/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_spec.rb -
ee/spec/lib/ee/gitlab/background_migration/remove_duplicated_cs_findings_without_vulnerability_id_spec.rb -
ee/spec/lib/ee/gitlab/background_migration/update_vulnerability_confidence_spec.rb -
ee/spec/lib/ee/gitlab/background_migration/remove_duplicate_cs_findings_spec.rb -
ee/spec/lib/ee/gitlab/background_migration/remove_undefined_occurrence_confidence_level_spec.rb -
ee/spec/lib/ee/gitlab/background_migration/remove_undefined_occurrence_severity_level_spec.rb -
ee/spec/lib/ee/gitlab/background_migration/backfill_version_data_from_gitaly_spec.rb(removed in !78184 (merged)) -
ee/spec/migrations/update_undefined_confidence_from_occurrences_spec.rb -
ee/spec/migrations/remove_duplicated_cs_findings_without_vulnerability_id_spec.rb -
ee/spec/migrations/update_cs_vulnerability_confidence_column_spec.rb -
ee/spec/migrations/update_location_fingerprint_column_for_cs_spec.rb -
ee/spec/migrations/remove_duplicated_cs_findings_spec.rb -
ee/spec/migrations/update_occurrence_severity_column_spec.rb
Edited by Michael Becker