Render empty Jira issue in GitLab (behind feature flag)
What does this MR do?
This is the initial MR for #298724 (closed). This MR:
- adds the
show
route for jira issues (/-/integrations/jira/issues/:id
) - the template currently only provides the mount point for the Vue app - mounts an empty Vue app
jira_issues_details_integration
. Without the feature flag enabled, the route will 404
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.9
added devopscreate groupecosystem [DEPRECATED] typemaintenance labels
added typefeature label
1 Message 📖 CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 52446 "Render empty Jira issue in GitLab (behind feature flag)"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 52446 "Render empty Jira issue in GitLab (behind feature flag)"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Maxime Orefice ( @morefice
) (UTC-5, 14.5 hours behind@tomquirk
)Mayra Cabrera ( @mayra-cabrera
) (UTC-6, 15.5 hours behind@tomquirk
)frontend Justin Ho ( @justin_ho
) (UTC+7, 2.5 hours behind@tomquirk
)Natalia Tepluhina ( @ntepluhina
) (UTC+1, 8.5 hours behind@tomquirk
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits c50e0466 and 0487d996
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.08 MB 3.08 MB - 0.0 % mainChunk 1.89 MB 1.89 MB - 0.0 % 🆕 New entry points: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.integrations.jira.issues.show 0 Bytes 1.25 MB +1.25 MB 100.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖added sectiondev label
- Resolved by Douglas Barbosa Alexandre
Hello @rpereira2 and @justin_ho, would you mind reviewing backend and frontend, respectively?
🙏
assigned to @rpereira2 and @justin_ho
marked the checklist item Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. as completed
mentioned in issue #298724 (closed)
- Resolved by Tom Quirk