[Rails5] Rename `sort` methods to `sort_by_attribute`

What does this MR do?

EE port of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/18142

Are there points in the code the reviewer needs to double check?

No.

Why was this MR needed?

Migration to Rails 5.0.

Screenshots (if relevant)

No.

Does this MR meet the acceptance criteria?

• Changelog entry added, if necessary
• Documentation created/updated
• API support added
• Tests added for this feature/bug
• Review
  • Has been reviewed by UX
  • Has been reviewed by Frontend
  • Has been reviewed by Backend
  • Has been reviewed by Database
• Conform by the merge request performance guides
• Conform by the style guides
• Squashed related commits together
• Internationalization required/considered
• If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
• End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/18142, https://gitlab.com/gitlab-org/gitlab-ce/issues/14286 and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12841