[Rails5] Rename `sort` methods to `sort_by_attribute`
What does this MR do?
Renames the sort methods of models to sort_by_attribute.
This is needed for migration to Rails 5.0 as in the fifth version Enumerable has been included to ActiveRecord::Relation.
So in Rails 5.0 the Enumerable#sort method is invoked instead of GitLab models' one.
Are there points in the code the reviewer needs to double check?
No.
Why was this MR needed?
Migration to Rails 5.0
Screenshots (if relevant)
No.
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Review
-
Has been reviewed by UX -
Has been reviewed by Frontend -
Has been reviewed by Backend -
Has been reviewed by Database
-
-
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together -
Internationalization required/considered -
End-to-end tests pass ( package-and-qamanual pipeline job)
What are the relevant issue numbers?
Edited by blackst0ne