Failsafe access to current user's email
What does this MR do?
Fixes #299207 (closed)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.9
added devopsplan groupproduct planning typebug labels
added frontend label
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Robert Hunt ( @rob.hunt
) (UTC+0)Jose Ivan Vargas ( @jivanvl
) (UTC-6)test Quality for spec/features/*
Désirée Chevalier ( @dchevalier2
) (UTC-5)Maintainer review is optional for test Quality for spec/features/*
If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 4525eab3 and 7926876d
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.07 MB 3.07 MB - 0.0 % mainChunk 1.89 MB 1.89 MB - 0.0 %
Note: We do not have exact data for 4525eab3. So we have used data from: 1d7c653b.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖@jprovaznik Can you please review this MR? Thanks!
😄 assigned to @jprovaznik
requested review from @jprovaznik
- Resolved by Rajat Jain
- Resolved by Rajat Jain
- Resolved by Rajat Jain
Thanks @rajatgitlab, overall LGTM, just some nits inline (also QA review is needed).
unassigned @jprovaznik
assigned to @jprovaznik
- Resolved by Désirée Chevalier
@dchevalier2: Can you please review this MR?
requested review from @dchevalier2
assigned to @dchevalier2
- Resolved by Rajat Jain
Thanks @rajatgitlab, BE LGTM
👍 , approved, please assign back to me when it has QA approval (unless merged meantime).
unassigned @jprovaznik
removed review request for @jprovaznik
assigned to @jprovaznik and unassigned @dchevalier2
removed review request for @dchevalier2
added Pick into auto-deploy priority2 severity2 labels
removed Pick into auto-deploy label
marked the checklist item Changelog entry as completed
Thanks @rajatgitlab, MWPS set
🚀 enabled an automatic merge when the pipeline for 432a10d9 succeeds
mentioned in commit 4476d625
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
picked the changes into the branch
13-8-stable-ee-patch-1
with commit ae7505fdmentioned in commit ae7505fd
Automatically picked into !52527 (merged), will merge into
13-8-stable-ee
ready for13.8.1-ee
.mentioned in merge request !52527 (merged)
added releasedcandidate label