Remove multiline_comments feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]
Merge request reports
Activity
changed milestone to %13.8
added backend devopscreate feature flag frontend groupcode review typemaintenance labels
added typefeature label
mentioned in issue #297684 (closed)
added documentation label
1 Warning This merge request changed files with disabled eslint rules. Please consider fixing them. 3 Messages This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 51763 "Remove multiline_comments feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 51763 "Remove multiline_comments feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
You're adding or removing a feature flag, your MR title needs to include [RUN ALL RSPEC] [RUN AS-IF-FOSS]
(we may have updated it automatically for you and started a new MR pipeline) to ensure everything is covered.Documentation review
The following files require a review from a technical writer:
doc/user/project/merge_requests/reviewing_and_managing_merge_requests.md
The review does not need to block merging this merge request. See the:
- Technical Writers assignments for the appropriate technical writer for this review.
- Documentation workflows for information on when to assign a merge request for review.
Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/batch_comments/components/draft_note.vue
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/batch_comments/components/draft_note.vue'
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Jason Goodman ( @jagood
) (UTC-5, 3 hours ahead of@kerrizor
)David Sincheol Kim ( @dskim_gitlab
) (UTC+10.5, 18.5 hours ahead of@kerrizor
)frontend Angelo Gulina ( @agulina
) (UTC+1, 9 hours ahead of@kerrizor
)Phil Hughes ( @iamphill
) (UTC+0, 8 hours ahead of@kerrizor
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 101 commits
-
a802b389...f9f972fb - 100 commits from branch
master
- 67c23c11 - Remove multiline_comments feature flag
-
a802b389...f9f972fb - 100 commits from branch
added sectiondev label
mentioned in issue #299121 (closed)
added 198 commits
-
795b07d4...ddad0826 - 197 commits from branch
master
- 3707ab4e - Remove multiline_comments feature flag
-
795b07d4...ddad0826 - 197 commits from branch
- Resolved by Kerri Miller
@thomasrandolph @jboyson If either of you has time, could you help me understand the Jest failures? I think it has something to do with
MultilineCommentForm
not being found, but.. I'm like Donny at the moment.
assigned to @thomasrandolph and @jboyson
added 176 commits
-
bf37c469...95223fe1 - 174 commits from branch
master
- c327f496 - Remove multiline_comments feature flag
- e11af966 - Fix failing jest tests
-
bf37c469...95223fe1 - 174 commits from branch
added 22 commits
-
e11af966...1ef8d7bb - 20 commits from branch
master
- ebd8dfaa - Remove multiline_comments feature flag
- 1f978ff7 - Fix failing jest tests
-
e11af966...1ef8d7bb - 20 commits from branch
unassigned @jboyson
unassigned @thomasrandolph
changed milestone to %13.9
added missed:13.8 label