Skip to content

refactor Security & Compliance Carousel Styles

Jannik Lehmann requested to merge jnnkl-refactor-security-carousel into master

What does this MR do?

This MR refactors the usage of the GL-Carousel in the Security & Compliance Carousel Styles

Its styling was updated in this MR !50877 (merged), which led to this follow-up Issue #297540 (closed).

The Task was to:

  1. Move the two style sheets with carousel styling into page-specific SCSS file, and use the add_page_specific_style helper to only add them for the project and group discover security pages ✅
  2. Replace all Bootstrap utility classes with GitLab UI utility classes ✅
  3. Move all carousel styling into GitLab UI ⛔ blocked by gitlab-ui!1951 (closed) By further investigation we noticed that only bootstrap's carousel styles are needed here. Which are already imported imported in GitLab UI
  4. gitlab-ui!1943 (merged) These newly introduced GitLab UI Mixins should be used to replace some of the styles ✅

Does the Carousel qualify to be a pajamas component?

No:

If the component is only relevant in one place (and we suspect it will only ever be relevant in one place), do not add to Pajamas.

Source

How to reproduce the page:

To reproduce this on your GDK:

  1. Make sure it is running without a license
  2. remove the check from this line
  3. Visit any group(!) dashboard and select the security tab

Screenshots (strongly suggested)

Screenshot_2021-01-18_at_12.57.44

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Dheeraj Joshi

Merge request reports