Optimize Security & Compliance Carousel
This is a follow up Issue for #290262 (closed) which was solved by !50877 (merged)
But a few things remained unsolved:
This is the only carousel (of any kind) in existence GitLab. It's definitely the only instance of GlCarousel
, anyway!
And, we have two SCSS files which control its appearance: app/assets/stylesheets/framework/carousel.scss
and ee/app/assets/stylesheets/pages/promotions.scss#L180-255
.
These styles are loaded for every page in GitLab, which is unnecessary. Plus, the carousel uses a bunch of Bootstrap utility classes which we're moving away from.
So, I propose some or all of the following (some of these may conflict with each other):
- Move the two style sheets with carousel styling into page-specific SCSS file, and use the
add_page_specific_style
helper to only add them for the project and group discover security pages - Replace all Bootstrap utility classes with GitLab UI utility classes
- Move all carousel styling into GitLab UI
- gitlab-ui!1943 (merged) These newly introduced GitLab UI Mixins should be used to replace some of the styles
Edited by Jannik Lehmann