Skip to content

Resolve long comments overflowing the container on MR Diffs when unified diff components is enabled

André Luís requested to merge 296222-resolve-long-comments-overflow into master

What does this MR do?

Solves a bug with the grids layout of diffs where overflowing context would extend far beyond the container's width.

The reason for why this fix works is described in this article: https://css-tricks.com/preventing-a-grid-blowout/

This MR tries to replace the existing proposed solution in !50715 (merged)

Screenshots (strongly suggested)

Before After
Screenshot_2021-01-04_at_14.43.55 Screenshot_2021-01-04_at_14.44.11
Screenshot_2021-01-04_at_14.48.35 Screenshot_2021-01-04_at_14.48.22
Screenshot_2021-01-04_at_14.37.43 Screenshot_2021-01-04_at_14.37.58
Screenshot_2021-01-04_at_14.47.45 Screenshot_2021-01-04_at_14.38.06

Covers:

  • draft comments - inline
  • draft comments - parallel
  • published comments - inline
  • published comments - parallel

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #296222 (closed)

Edited by André Luís

Merge request reports