Resolve "Long comments overflow container on merge diffs"
What does this MR do?
Adds gl-overflow-auto
to keep notes content from overflowing its parent.
Solves a bug with the grids layout of diffs where overflowing context would extend far beyond the container's width.
Changes 1fr
usage in grid-template-columns:
to minmax(0, 1fr)
on relevant containers.
The reason for why this fix works is described in this article: https://css-tricks.com/preventing-a-grid-blowout/
Screenshots (strongly suggested)
Broken | Fixed |
---|---|
Some more after last update of code base:
Mode | Screenshot (fixed) |
---|---|
parallel | |
inline |
Covers:
- Draft comments - inline
- Draft comments - parallel
- Published comments - inline
- Published comments - parallel
- Preview comment box - inline
- Preview comment box - parallel
Does this MR meet the acceptance criteria?
Conformity
Related to #296222 (closed)
Edited by André Luís