Skip to content

Adds delete functionality to metric images

Tristan Read requested to merge tr-metric-image-delete into master

What does this MR do?

Adds delete functionality to metric images.

Issue: #291011 (closed)

Feature flag: incident_metric_upload_ui

License: GitLab Premium or above

Note: targets tr-upload-metric-images. Re-target to master when !46731 (merged) is merged. Done

Screenshots (strongly suggested)

before after
Screenshot_2020-12-16_at_00.42.49 Screenshot_2020-12-16_at_00.42.31
confirmation dialog
Screenshot_2021-01-13_at_11.09.42
error message
Screenshot_2020-12-16_at_00.44.16

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [n/a] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [n/a] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [n/a] Security reports checked/validated by a reviewer from the AppSec team
Edited by Tristan Read

Merge request reports