Skip to content

Add upload feature for metric images

Tristan Read requested to merge tr-upload-metric-images into master

What does this MR do?

Incidents (an extensible issue type) now have a 'Metrics' tab. This tab contains an upload area similar to the design management upload feature, in that users may attach images.

Users may optionally add a url to the metric image, which adds a link to the title when it is displayed.

There is a fast follow-up to allow metric images to be deleted: #291011 (closed).

Notes:

  1. This feature is behind the feature flag :incident_metric_upload_ui. Run Feature.enable(:incident_metric_upload_ui) in the rails console to enable it.
  2. Requires a GitLab Premium or above license.

Issue: #235994 (closed)

More info:

Screenshots (strongly suggested)

Incident with empty metrics tab URL dialog Incident with attached metric (and url) Collapsed metric
Screenshot_2020-12-14_at_20.48.17 Screenshot_2020-12-14_at_20.49.37 Screenshot_2020-12-14_at_20.50.45 Screenshot_2020-12-14_at_20.50.59

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [n/a] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [n/a] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [n/a] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports