Refactor and Clean Up tests for Subscription table component
What does this MR do?
Relates to gitlab-org/customers-gitlab-com#2305, this is a series of MR planning to add a button to give customers the possibility to add more seats. The reason of separating it is the complications arising from the multi=project handling plus the fact that it should be faster getting merged
The Plan
| Description | MR |
|---|---|
| backend Add the Feature Flag and the new URL | !49242 (merged) |
| backend Redirect for the new URL (on CustomersDot) | gitlab-org/customers-gitlab-com!2307 |
| frontend Add the Button on the Frontend | !49548 (merged) |
| frontend Refactor injected vars and tests |
|
| Roll-out the feature | tbd |
Changes
This MR adds refactors:
- the component: using GitLab UI Component for the link
- the component: using GitLab UI Utils where possible
- the component: moving from props to injected
- the tests: from snapshots to more granular testing
- the tests: from all the buttons to single per button
- the tests: add missing pieces
Screenshots (strongly suggested)
 |
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Angelo Gulina