Implement exit code functionality for allow_failure
What does this MR do?
Related to #273157 (closed)
This is the follow up from !49145 (merged) which implemented the syntax.
If a job has failed, the runner is sending the job's exit code back to Rails. We compare this exit code with the ones defined in the yaml and update ci_builds.allow_failure
to true
if they intersect.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.7
1 Message 📖 CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 49462 "Implement exit code functionality for allow_failure"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 49462 "Implement exit code functionality for allow_failure"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Nikola Milojevic ( @nmilojevic1
) (UTC+1, 1 hour behind@mbobin
)Mayra Cabrera ( @mayra-cabrera
) (UTC-6, 8 hours behind@mbobin
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖mentioned in merge request !49145 (merged)
- Resolved by Fabio Pitino
- Resolved by Marius Bobin
assigned to @furkanayhan
@mbobin Looks good
💯 unassigned @furkanayhan
mentioned in merge request !49580 (merged)
added 1112 commits
-
ab534112...1412094f - 1111 commits from branch
ci-add-exit-code-syntax
- 8529b8ce - Accept exit codes from runner and mark jobs as allowed to fail
-
ab534112...1412094f - 1111 commits from branch
added 58 commits
-
8529b8ce...a30bdc7f - 57 commits from branch
master
- fd375b8a - Accept exit codes from runner and mark jobs as allowed to fail
-
8529b8ce...a30bdc7f - 57 commits from branch
assigned to @grzesiek
- Resolved by Fabio Pitino
- Resolved by Fabio Pitino
- Resolved by Fabio Pitino
@mbobin a few questions!
unassigned @grzesiek
assigned to @grzesiek
changed milestone to %13.8
added missed:13.7 label
- Resolved by Fabio Pitino
@fabiopitino could you take over the maintainer review here?
🙏
assigned to @fabiopitino and unassigned @grzesiek
- Resolved by Fabio Pitino
- Resolved by Fabio Pitino
- Resolved by Fabio Pitino
unassigned @fabiopitino
added 836 commits
-
127a4eec...c38c150c - 833 commits from branch
master
- 7dadebc9 - Accept exit codes from runner and mark jobs as allowed to fail
- d0802850 - Implement maintainer feedback
- fb0ec381 - Implement maintainer feedback
Toggle commit list-
127a4eec...c38c150c - 833 commits from branch
assigned to @fabiopitino
- Resolved by Marius Bobin
unassigned @fabiopitino
assigned to @fabiopitino
enabled an automatic merge when the pipeline for f59aba33 succeeds
mentioned in commit 065c88d7
added workflowstaging label and removed workflowin dev label
added workflowcanary label and removed workflowstaging label
mentioned in merge request gitlab-runner!2645 (merged)