Skip to content
Snippets Groups Projects

Implement exit code functionality for allow_failure

Merged Marius Bobin requested to merge ci-implement-exit-code-functionality into master

What does this MR do?

Related to #273157 (closed)

This is the follow up from !49145 (merged) which implemented the syntax.

If a job has failed, the runner is sending the job's exit code back to Rails. We compare this exit code with the ones defined in the yaml and update ci_builds.allow_failure to true if they intersect.

Screenshots (strongly suggested)

!49145 (merged)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Marius Bobin

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marius Bobin
  • Furkan Ayhan approved this merge request

    approved this merge request

  • @mbobin Looks good 💯

  • Marius Bobin mentioned in merge request !49580 (merged)

    mentioned in merge request !49580 (merged)

  • Marius Bobin added 1112 commits

    added 1112 commits

    • ab534112...1412094f - 1111 commits from branch ci-add-exit-code-syntax
    • 8529b8ce - Accept exit codes from runner and mark jobs as allowed to fail

    Compare with previous version

  • Marius Bobin changed target branch from ci-add-exit-code-syntax to master

    changed target branch from ci-add-exit-code-syntax to master

  • Marius Bobin added 58 commits

    added 58 commits

    Compare with previous version

  • assigned to @grzesiek

  • Marius Bobin added 1 commit

    added 1 commit

    • 6b077d5b - Implement maintainer feedback

    Compare with previous version

  • assigned to @grzesiek

  • Marius Bobin added 1 commit

    added 1 commit

    • 127a4eec - Implement maintainer feedback

    Compare with previous version

  • 🤖 GitLab Bot 🤖 changed milestone to %13.8

    changed milestone to %13.8

  • Marius Bobin assigned to @fabiopitino and unassigned @grzesiek

    assigned to @fabiopitino and unassigned @grzesiek

  • Fabio Pitino resolved all threads

    resolved all threads

  • Fabio Pitino
  • Marius Bobin added 836 commits

    added 836 commits

    Compare with previous version

  • Marius Bobin added 1 commit

    added 1 commit

    • 339596b2 - Replace private methods with public ones

    Compare with previous version

  • Fabio Pitino resolved all threads

    resolved all threads

  • Fabio Pitino approved this merge request

    approved this merge request

  • Fabio Pitino enabled an automatic merge when the pipeline for f59aba33 succeeds

    enabled an automatic merge when the pipeline for f59aba33 succeeds

  • merged

  • Fabio Pitino mentioned in commit 065c88d7

    mentioned in commit 065c88d7

  • added workflowstaging label and removed workflowin dev label

  • added workflowcanary label and removed workflowstaging label

  • mentioned in merge request gitlab-runner!2645 (merged)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading