Fix pages object storage bucket
requested to merge 291088-pages-uploader-considers-object-storage-enabled-even-if-bucket-isn-t-configured into master
What does this MR do?
In e9126f52 we added the ability to use consolidate object storage for pages.
But if consolidate object storage is used but bucket isn't set pages deployments fail: #291088 (closed)
This MR just prevent consolidated object storage settings to be set to pages uploader if bucket is not set.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #291088 (closed)
Edited by Kamil Trzciński