Make pages_use_legacy_storage_lease default to true
What does this MR do?
Enables pages_use_legacy_storage_lease
by default.
I tested this in production and run 10-15 pipelines at the same time on https://gitlab.com/vshushlin/pages-direct/-/pipelines, I managed to create a couple of exceptions https://sentry.gitlab.net/gitlab/gitlabcom/issues/2403448/?query=is%3Aunresolved%20ExclusiveLeaseTaken and 2 pipelines were red for a moment, but the worker was restarted and pipeline was green again in a few seconds.
I'll create another issue for removing the feature flag.
Related to #282464 (closed)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński